Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional resolver panics on response without question #1148

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Sep 15, 2023

closes #1113

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Sep 15, 2023
@0xERR0R 0xERR0R added this to the v0.23 milestone Sep 15, 2023
@ThinkChaos
Copy link
Collaborator

Looks like #1147 broke the CI even though it worked in that PR...
Besides that looks good to me!

@0xERR0R
Copy link
Owner Author

0xERR0R commented Sep 16, 2023

Looks like #1147 broke the CI even though it worked in that PR...
Besides that looks good to me!

Yes, codecov action was updated by dependabot pr. But this version is currently beta. I reverted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blocky process panics if the conditiononal upstream resolver receives a response without a question section
3 participants