-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer & unit test refactoring #1220
devcontainer & unit test refactoring #1220
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 2 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
Thought of a better way to achieve automatic background testing. |
@0xERR0R & @ThinkChaos I started refactoring the unit tests in this PR to enable parallel execution. Since this is still flaky I disabled it in GitHub workflow execution. The GitHub runners provide 2 cores therefore enabling I fixed the most problematic parts but there are still way too many local variables which are against the ginkgo principal (variables shouldn't be declared inside the deepest level). Also initialization should be done outside the test itself in BeforeEach, BeforeAll, etc. I enabled parallel execution in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The port thing doesn't necessarily need to be changed now, do as you wish :)
Devcontainer changes:
Unit test changes:
Workflow changes:
Makefile changes:
-p
if GINKGO_PROCS isn't specified