Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/GitHub workflows #1234

Merged
merged 7 commits into from
Nov 14, 2023
Merged

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 12, 2023

Changes

  • fixes the mirror-repo workflow I broke yesterday
  • added Github-Actions plugin to devcontainer
  • set prettier as default formatter for github workflows in devcontainer
  • removed default settings from devcontainer.json
  • reformatted all workflows for uniformity
  • removed Mattraks/delete-workflow-runs since its filter is broken

@kwitsch kwitsch added the 🐞 bug Something isn't working label Nov 12, 2023
@kwitsch kwitsch added this to the v0.23 milestone Nov 12, 2023
@kwitsch kwitsch enabled auto-merge (squash) November 12, 2023 14:54
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7615584) 93.63% compared to head (65574fb) 93.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   93.63%   93.70%   +0.07%     
==========================================
  Files          70       70              
  Lines        5687     5687              
==========================================
+ Hits         5325     5329       +4     
+ Misses        280      277       -3     
+ Partials       82       81       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwitsch
Copy link
Collaborator Author

kwitsch commented Nov 12, 2023

@0xERR0R & @ThinkChaos the cause of the failing repo mirror workflow(on every merge) is a faulty indentation in the yaml file.
This is fixed in this PR.

@kwitsch
Copy link
Collaborator Author

kwitsch commented Nov 14, 2023

The filter option of Mattraks/delete-workflow-runs@v2 seems broken. I'll remove it later today.

@kwitsch
Copy link
Collaborator Author

kwitsch commented Nov 14, 2023

@0xERR0R since the Delete workflow runs is faulty and will be removed with this PR and Sync Fork is always skipped in this repo I disabled these two workflows.

@kwitsch kwitsch requested a review from 0xERR0R November 14, 2023 18:45
@kwitsch kwitsch merged commit fb8c419 into 0xERR0R:main Nov 14, 2023
11 checks passed
@kwitsch kwitsch deleted the bugfix/github-workflows branch November 14, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants