Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test refactoring #1245

Merged
merged 15 commits into from
Nov 15, 2023
Merged

Unit test refactoring #1245

merged 15 commits into from
Nov 15, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 14, 2023 •
edited
Loading

Changes:

  • lcov.info is generated seperately for each subfolder(devcontainer)
  • added dot-import-whitelist to golangci.yml for comonly used global test imports
  • moved mock_call_sequence.go to helpertest package
  • consolidated some strings in tests
  • updated ginkgo to v2.13.1

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7edb856) 93.65% compared to head (c6d0d0c) 93.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
+ Coverage   93.65%   93.70%   +0.05%     
==========================================
  Files          70       70              
  Lines        5687     5687              
==========================================
+ Hits         5326     5329       +3     
+ Misses        279      277       -2     
+ Partials       82       81       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kwitsch kwitsch enabled auto-merge (squash) November 14, 2023 19:40
@kwitsch kwitsch mentioned this pull request Nov 14, 2023
Merged
0xERR0R
0xERR0R approved these changes Nov 15, 2023
View reviewed changes
Copy link
Owner

@0xERR0R 0xERR0R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kwitsch
Copy link
Collaborator Author

kwitsch commented Nov 15, 2023

Closes #1251

@kwitsch kwitsch merged commit 6c00009 into 0xERR0R:main Nov 15, 2023
11 checks passed
@kwitsch kwitsch deleted the feature/test-cleanup branch November 15, 2023 15:42
@0xERR0R 0xERR0R mentioned this pull request Nov 15, 2023
Closed
ThinkChaos
ThinkChaos approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@ThinkChaos ThinkChaos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's conflicts now though!

EDIT: too slow 😄

@0xERR0R 0xERR0R added this to the v0.23 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xERR0R 0xERR0R 0xERR0R approved these changes

@ThinkChaos ThinkChaos ThinkChaos approved these changes

Assignees
No one assigned
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Milestone
v0.23
Development

Successfully merging this pull request may close these issues.
3 participants
@kwitsch @ThinkChaos @0xERR0R