Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: FileDownloader #1281

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Refactoring: FileDownloader #1281

merged 7 commits into from
Nov 29, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Nov 29, 2023

Changes:

  • enabled context linters
  • made e2e-tests use ginkgo context
  • made file downloader context aware
  • fixed linter findings

Part of #1264

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Nov 29, 2023
@kwitsch kwitsch mentioned this pull request Nov 29, 2023
Open
11 tasks
@kwitsch kwitsch merged commit 3378316 into 0xERR0R:main Nov 29, 2023
9 checks passed
@kwitsch kwitsch deleted the refactoring/FileDownloader branch November 29, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThinkChaos ThinkChaos ThinkChaos approved these changes

Assignees
No one assigned
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwitsch @ThinkChaos