Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a variable to select the job in the grafana dashboard #1326

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

shizunge
Copy link
Contributor

@shizunge shizunge commented Jan 7, 2024

Do not hardcode the job name in the grafana dashboard.

User cannot set the job name in Grafana Cloud. (non self hosted prometheus)

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5cde62f) 93.80% compared to head (f360e34) 93.80%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   93.80%   93.80%           
=======================================
  Files          77       77           
  Lines        6200     6200           
=======================================
  Hits         5816     5816           
  Misses        295      295           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xERR0R
Copy link
Owner

0xERR0R commented Jan 17, 2024

Thank you!

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Jan 17, 2024
@0xERR0R 0xERR0R added this to the v0.24 milestone Jan 17, 2024
@0xERR0R 0xERR0R merged commit 95bd013 into 0xERR0R:main Jan 17, 2024
11 checks passed
@FutureCow
Copy link

Tried this new JSON, but for me it's not working. This is my grafana page:
image
When I change $job to blocky, I can see the values again.
Also get an error when pushing one of the buttons, but dont know if that's related.

@shizunge
Copy link
Contributor Author

Tried this new JSON, but for me it's not working. This is my grafana page: image When I change $job to blocky, I can see the values again. Also get an error when pushing one of the buttons, but dont know if that's related.

What is Ganfana version? I failed to reproduce your issue with Grafana v10.4.0-65039.

@FutureCow
Copy link

I'm running the latest stable: Grafana v10.3.3

Grafana is running native on the system
Blocky: v0.23-44-g07b864e inside docker container
Prometheus: version="2.45.3+ds" running native on the system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants