Added version to web interface.

[Harnish]

I broke this out to its own little change since I wanted to get your feedback on using the makefile to put the version into server.go vs passing it along.

I am trying to decom my project https://github.com/Harnish/https-dns-proxy and move the fun bits into blocky.

[codecov]

Codecov Report

Merging #195 (1d6ab01) into development (dd69a3e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #195      +/-   ##
===============================================
+ Coverage        93.79%   93.82%   +0.02%     
===============================================
  Files               27       27              
  Lines             1741     1749       +8     
===============================================
+ Hits              1633     1641       +8     
  Misses              80       80              
  Partials            28       28              

Impacted Files	Coverage Δ
cmd/root.go	70.37% <ø> (ø)
cmd/serve.go	66.66% <100.00%> (ø)
cmd/version.go	100.00% <100.00%> (ø)
server/server_endpoints.go	87.50% <100.00%> (+0.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd69a3e...1d6ab01. Read the comment docs.

[0xERR0R]

Hi,
thanks for the suggestion. The idea is good to display the version number in the initial web page. Currently, blocky uses the version number in 2 places:

• Server startup: shows the version in the banner (serve.go, will be injected in the makefile)
• Prometheus metric (metric_event_publisher.go, receives the version number via application event over the event bus. The event will be sent in serve.go - startServer func)

I think, it would be better to receive the event in Server (same logic as in metric_event_publisher) via event bus and not to duplicate the injection in the make file.

Another approach would be to move the version number to a common place and inject it only once.

What do you think?

[0xERR0R]

I moved version and build time to the util package (to avoid duplication of variables) and tested your PR -> looks good. I added also build time to the web interface, so the web UI shows the same information as the log file.

Thanks for you work!

[0xERR0R]

Closes #203