WhitelistOnly Fix for multiple entries #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WhitelistOnly is only used, if no more than two whitelists are available or all clients include all whitelists.
Look at the following config snippet. Two Groups are defined, each with their own set of "whitelist" entries.
If multiple WhitelistOnly groups are defined, then every client, which do NOT include ALL whitelists, can resolve non-whitelist items.
The
reflect.DeepEqual()
list now contains the check if[net_one] == [net_one, net_two]
, which will always return false.Expected Behavior: Both clients are restricted to the defined whitelistOnly domains.
Behavior: None of them have whitelist enabled.
Possible solution
I changed the data type from slice to dict for performance reason.
Best regards,
c-f