-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable caching for negative results (NXDOMAIN) (#287) #330
Conversation
Isen't needed in main repository
Codecov Report
@@ Coverage Diff @@
## development #330 +/- ##
============================================
Coverage 96.26% 96.27%
============================================
Files 29 29
Lines 2198 2200 +2
============================================
+ Hits 2116 2118 +2
Misses 53 53
Partials 29 29
Continue to review full report at Codecov.
|
.gitignore
Outdated
@@ -13,3 +13,4 @@ todo.txt | |||
!docs/config.yml | |||
node_modules | |||
package-lock.json | |||
Dockerfile.Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is something from your local tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, please run "go mod tidy" and commit the changes, I think there is something wrong
Sorry currently not at home. |
Thanks for your work, I had some spare time today and I think we can merge it now |
Changes:
closes #287