Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make go:build compatible with go 1.16 #361

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

ThinkChaos
Copy link
Collaborator

@ThinkChaos ThinkChaos commented Dec 11, 2021

#267 broke building on older go versions. This fixes it.
I also made sure it still builds with 1.17.

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #361 (395888e) into development (3fa79b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #361   +/-   ##
============================================
  Coverage        96.14%   96.14%           
============================================
  Files               30       30           
  Lines             2230     2230           
============================================
  Hits              2144     2144           
  Misses              56       56           
  Partials            30       30           
Impacted Files Coverage Δ
server/server_config_trigger.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fa79b4...395888e. Read the comment docs.

@ThinkChaos
Copy link
Collaborator Author

Looks like an unrelated failure. Can you retry?

@0xERR0R
Copy link
Owner

0xERR0R commented Dec 11, 2021

Thanks for your work. I don't understand, why there is a problem with golangci-lint. I'll merge it

@0xERR0R 0xERR0R added this to the 0.18 milestone Dec 11, 2021
@0xERR0R 0xERR0R merged commit 25ad3a9 into 0xERR0R:development Dec 11, 2021
@ThinkChaos ThinkChaos deleted the fix/go-build branch December 12, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants