Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run docker build on fork #402

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

FileGo
Copy link
Collaborator

@FileGo FileGo commented Jan 10, 2022

Fixes #401.

@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #402 (524b4a8) into development (02e1aa5) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #402      +/-   ##
===============================================
- Coverage        94.10%   93.95%   -0.16%     
===============================================
  Files               32       32              
  Lines             2546     2546              
===============================================
- Hits              2396     2392       -4     
- Misses             112      115       +3     
- Partials            38       39       +1     
Impacted Files Coverage Δ
resolver/caching_resolver.go 95.27% <0.00%> (-3.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e1aa5...524b4a8. Read the comment docs.

@0xERR0R
Copy link
Owner

0xERR0R commented Jan 10, 2022

Do we have the same problem with "Upload results to codecov" step?

@FileGo
Copy link
Collaborator Author

FileGo commented Jan 10, 2022

Do we have the same problem with "Upload results to codecov" step?

It works fine, but not sure if that's the desired behaviour? Is there any benefit in codecov upload running on forks?

@0xERR0R
Copy link
Owner

0xERR0R commented Jan 10, 2022

I was just wondering, why this PR has changed the code coverage. I think, this step can run on forks, but codecov should not consider any results from fork build. Not sure, how it currently works 🤷

@0xERR0R 0xERR0R merged commit 04b21e4 into 0xERR0R:development Jan 10, 2022
@FileGo
Copy link
Collaborator Author

FileGo commented Jan 10, 2022

Yeah, not sure either really, it's only one line in a GH yaml 😐

@FileGo FileGo deleted the docker_development_build branch May 17, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development docker build fails on fork
2 participants