Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gingko v2 #447

Merged
merged 4 commits into from
Mar 3, 2022
Merged

Conversation

ThinkChaos
Copy link
Collaborator

I did this to be able to use the gingko CLI tool.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #447 (72feeaf) into development (1253913) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #447   +/-   ##
============================================
  Coverage        94.19%   94.19%           
============================================
  Files               33       33           
  Lines             2722     2722           
============================================
  Hits              2564     2564           
  Misses             120      120           
  Partials            38       38           
Impacted Files Coverage Δ
querylog/database_writer.go 96.82% <100.00%> (ø)
querylog/file_writer.go 100.00% <100.00%> (ø)
querylog/logger_writer.go 100.00% <100.00%> (ø)
querylog/none_writer.go 100.00% <100.00%> (ø)
resolver/query_logging_resolver.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1253913...72feeaf. Read the comment docs.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@0xERR0R
Copy link
Owner

0xERR0R commented Mar 2, 2022

@ThinkChaos : Thanks, this is really cool. I was not aware that there was a new version of ginkgo. I'll test it asap. One question: in your PR there are some downgrades in the go.mod. Did you started your PR branch on the latest commit from "development" branch?

@ThinkChaos
Copy link
Collaborator Author

Ah good catch, I glossed over that file.
I'll double check later but I did do a lot of branches and rebasing cause I started this to be able to write tests for a bigger change I made. I'll get back to you ASAP.

Yeah dependabot doesn't seem to detect this. I've never set it up myself so no clue if there's an option for it.

@ThinkChaos
Copy link
Collaborator Author

I manually reverted the downgrades and ran go mod tidy. Should be good now!

@0xERR0R 0xERR0R self-assigned this Mar 3, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone Mar 3, 2022
@0xERR0R 0xERR0R added the ⚙️ dependencies Pull requests that update a dependency file label Mar 3, 2022
@0xERR0R 0xERR0R merged commit 27c8cbf into 0xERR0R:development Mar 3, 2022
@ThinkChaos ThinkChaos deleted the chore/gingko-v2 branch March 4, 2022 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants