Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unexpanded CMD variable with correct defaulting behavior. #478

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

ohemmali
Copy link
Contributor

@ohemmali ohemmali commented Apr 1, 2022

After further testing, defaulting was not correctly occurring. Switching to env var expansion with embedded default value.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #478 (3f003c8) into development (5427c16) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #478   +/-   ##
============================================
  Coverage        94.63%   94.63%           
============================================
  Files               35       35           
  Lines             2761     2761           
============================================
  Hits              2613     2613           
  Misses             114      114           
  Partials            34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5427c16...3f003c8. Read the comment docs.

@0xERR0R 0xERR0R merged commit 4d1f09f into 0xERR0R:development Apr 1, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants