Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the indent of yaml code block in docs/configuration.md #481

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Apr 2, 2022

There's something wrong with the old one, there are inconsistent and broken indent in it 😅

@PeterDaveHello PeterDaveHello force-pushed the fix-indent-in-docs/configuration.md branch 2 times, most recently from 2195ec9 to d38908f Compare April 2, 2022 13:11
@PeterDaveHello PeterDaveHello force-pushed the fix-indent-in-docs/configuration.md branch from d38908f to b148f5e Compare April 2, 2022 13:14
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #481 (b148f5e) into development (4d1f09f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #481   +/-   ##
============================================
  Coverage        94.63%   94.63%           
============================================
  Files               35       35           
  Lines             2796     2796           
============================================
  Hits              2646     2646           
  Misses             115      115           
  Partials            35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1f09f...b148f5e. Read the comment docs.

@0xERR0R
Copy link
Owner

0xERR0R commented Apr 2, 2022

Good catch 👍
I had problems in the past with auto formatting on save in Goland: it has periodically broke yaml formatting inside the MD file. I thought, I fixed it. 🙅

@0xERR0R 0xERR0R merged commit 45fae43 into 0xERR0R:development Apr 2, 2022
@PeterDaveHello PeterDaveHello deleted the fix-indent-in-docs/configuration.md branch April 2, 2022 20:38
@PeterDaveHello
Copy link
Contributor Author

@0xERR0R thanks! BTW, does https://github.com/0xERR0R/blocky/tree/gh-pages need a manual build to update its content?

@0xERR0R
Copy link
Owner

0xERR0R commented Apr 3, 2022

It will be updated on master commit or when development branch will be merged on master. I merge usually just before new release, because documentation can contain description of new parameters (future release).

@0xERR0R
Copy link
Owner

0xERR0R commented Apr 3, 2022

I think, I'll cherry pick your commit to update the doc page.

@PeterDaveHello
Copy link
Contributor Author

No rush 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants