Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update golangci-lint #510

Merged
merged 23 commits into from
May 10, 2022
Merged

update golangci-lint #510

merged 23 commits into from
May 10, 2022

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented May 8, 2022

Updated golangci-lint to the latest version. Enabled additional linters:

  • wastedassign
  • tenv
  • sqlclosecheck
  • predeclared
  • nolintlint
  • nlreturn
  • nilnil
  • nilerr
  • nestif
  • makezero
  • importas
  • grouper
  • ifshort
  • grouper
  • gomodguard
  • gomoddirectives
  • exhaustive
  • errorlint
  • errchkjson
  • durationcheck
  • bidichk
  • asciicheck
  • gomnd

@0xERR0R 0xERR0R added the ⚙️ dependencies Pull requests that update a dependency file label May 8, 2022
@0xERR0R 0xERR0R added this to the 0.19 milestone May 8, 2022
@codecov
Copy link

codecov bot commented May 8, 2022

Codecov Report

Merging #510 (f3f28f6) into development (41febaf) will increase coverage by 0.05%.
The diff coverage is 90.64%.

@@               Coverage Diff               @@
##           development     #510      +/-   ##
===============================================
+ Coverage        93.78%   93.84%   +0.05%     
===============================================
  Files               36       36              
  Lines             3056     3085      +29     
===============================================
+ Hits              2866     2895      +29     
  Misses             142      142              
  Partials            48       48              
Impacted Files Coverage Δ
cache/stringcache/string_caches.go 100.00% <ø> (ø)
cmd/lists.go 100.00% <ø> (ø)
cmd/query.go 88.88% <ø> (ø)
cmd/serve.go 65.95% <0.00%> (-1.44%) ⬇️
lists/downloader.go 100.00% <ø> (ø)
resolver/rewriter_resolver.go 96.66% <ø> (ø)
redis/redis.go 66.44% <55.00%> (ø)
cmd/root.go 58.53% <60.00%> (+1.39%) ⬆️
resolver/client_names_resolver.go 96.38% <88.46%> (+0.04%) ⬆️
cache/expirationcache/expiration_cache.go 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41febaf...f3f28f6. Read the comment docs.

@0xERR0R 0xERR0R merged commit a4b8953 into development May 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the golangci-lint branch May 10, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant