Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DoT server TLS cipher suites #520

Merged

Conversation

PeterDaveHello
Copy link
Contributor

This removes some VULNERABLE, or potentially VULNERABLE ciphers, like Triple DES and Obsoleted CBC ciphers, for the DoT server.

For the cipher suggestions, we can refer to Mozilla SSL Configuration Generator:

This removes some VULNERABLE, or potentially VULNERABLE ciphers, like
Triple DES and Obsoleted CBC ciphers, for the DoT server.
@PeterDaveHello
Copy link
Contributor Author

Not sure why the cipher change would break the test 🤔

@0xERR0R 0xERR0R added this to the 0.19 milestone May 16, 2022
@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label May 16, 2022
@0xERR0R
Copy link
Owner

0xERR0R commented May 16, 2022

Not sure why the cipher change would break the test thinking

There are some tests which test cache expiration, sometimes is github environment too slow. I can't reproduce it locally, I want to rewrite those tests in the near future

@0xERR0R
Copy link
Owner

0xERR0R commented May 16, 2022

Thanks for your work! I did not know the site from mozilla, very cool!

@0xERR0R 0xERR0R merged commit 4780b48 into 0xERR0R:development May 16, 2022
@PeterDaveHello PeterDaveHello deleted the Improve-DoT-Server-TLS-cipher branch May 17, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants