Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.18 #540

Merged
merged 3 commits into from
May 27, 2022
Merged

Update to Go 1.18 #540

merged 3 commits into from
May 27, 2022

Conversation

FileGo
Copy link
Collaborator

@FileGo FileGo commented May 25, 2022

Updated things to Go 1.18. Also upgraded the Alpine Linux version in Dockerfile, as 3.16 has been released recently.

Lint action fails, but this has been addressed in #536, so should be fine once it's merged.

@ThinkChaos
Copy link
Collaborator

I think you need to run go mod tidy to update the go.mod and go.sum files, 1.18 now splits direct and indirect dependencies in multiple require blocks.

@0xERR0R 0xERR0R linked an issue May 27, 2022 that may be closed by this pull request
@0xERR0R 0xERR0R added this to the 0.19 milestone May 27, 2022
@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #540 (87da9d8) into development (8d0bd8e) will increase coverage by 1.19%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #540      +/-   ##
===============================================
+ Coverage        93.73%   94.92%   +1.19%     
===============================================
  Files               36       36              
  Lines             3112     3312     +200     
===============================================
+ Hits              2917     3144     +227     
+ Misses             145      116      -29     
- Partials            50       52       +2     
Impacted Files Coverage Δ
config/config.go 95.91% <0.00%> (-2.23%) ⬇️
server/server.go 90.33% <0.00%> (+4.51%) ⬆️
redis/redis.go 90.78% <0.00%> (+24.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0bd8e...87da9d8. Read the comment docs.

@0xERR0R
Copy link
Owner

0xERR0R commented May 27, 2022

Thanks!

@0xERR0R 0xERR0R merged commit 2944deb into 0xERR0R:development May 27, 2022
@FileGo FileGo deleted the go1.18 branch May 29, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Go 1.18
3 participants