feat: querylog: define which information should be logged (#765) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportBase: 89.15% // Head: 89.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## development #766 +/- ##
===============================================
+ Coverage 89.15% 89.33% +0.17%
===============================================
Files 42 42
Lines 4833 4876 +43
===============================================
+ Hits 4309 4356 +47
+ Misses 454 451 -3
+ Partials 70 69 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ThinkChaos
reviewed
Nov 25, 2022
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
kwitsch
approved these changes
Nov 25, 2022
0xERR0R
commented
Nov 16, 2023
Comment on lines
-114
to
-115
| util.QuestionToString(request.Req.Question), | ||
| util.AnswerToString(response.Res.Answer), |
There was a problem hiding this comment.
Obfuscates question and answer if log privacy is enabled
0xERR0R
commented
Nov 16, 2023
| entry.Answer = util.AnswerToString(response.Res.Answer) | ||
|
|
||
| case config.QueryLogFieldQuestion: | ||
| entry.QuestionName = request.Req.Question[0].Name |
There was a problem hiding this comment.
should use util.QuestionToString -> this will obfuscate question if log privacy is enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #765