-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config restructuring #771
Config restructuring #771
Conversation
Codecov ReportBase: 92.93% // Head: 93.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## development #771 +/- ##
===============================================
+ Coverage 92.93% 93.04% +0.11%
===============================================
Files 41 41
Lines 4697 4744 +47
===============================================
+ Hits 4365 4414 +49
+ Misses 263 261 -2
Partials 69 69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good!
Co-authored-by: Dimitri Herzog <dimitri.herzog@gmail.com>
Co-authored-by: Dimitri Herzog <dimitri.herzog@gmail.com>
…ructuring # Conflicts: # log/logger.go
…blocky-dev into fb-config_restructuring
@0xERR0R |
To declutter the global top level config options i propose the grouping of ports and logging options as child options of top level options.
Example:
Full backward compatibility is provided through
validateConfig
and subsequentlyfixDeprecatedLog
andfixDeprecatedPorts
.The documentation an unit tests are modified to use the new structure as default.