Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolver): crash when using client upstream (#791) #793

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Dec 9, 2022

closes #791

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Dec 9, 2022
@0xERR0R 0xERR0R added this to the 0.21 milestone Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Base: 93.33% // Head: 93.42% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (4ab7764) compared to base (e08e609).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #793      +/-   ##
===============================================
+ Coverage        93.33%   93.42%   +0.09%     
===============================================
  Files               42       42              
  Lines             4845     4869      +24     
===============================================
+ Hits              4522     4549      +27     
+ Misses             254      252       -2     
+ Partials            69       68       -1     
Impacted Files Coverage Δ
resolver/parallel_best_resolver.go 100.00% <100.00%> (ø)
resolver/upstream_resolver.go 89.30% <0.00%> (+0.11%) ⬆️
resolver/query_logging_resolver.go 98.68% <0.00%> (+0.18%) ⬆️
redis/redis.go 93.23% <0.00%> (+1.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@kwitsch kwitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kwitsch kwitsch merged commit 87779d5 into development Dec 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-upstream-crash branch December 9, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIGSEGV crash when using client upstream
2 participants