Test refactoring

[0xERR0R]

Some small improvements:

• make tests more readable:

  • replace for example dns.Type(dns.TypeA) with A constant
  • add special assert functions to check TTL, Response, Return type
  • Squash multiple assertions on Response to one "Expect" call
  • remove "hidden" and "nested" assertions and variable definition in "beforeEach"
  • DNS response assertions can now be applied direct to model.Response, this make error check unnecessary (since gomega does it)

• remove TTL check from ´BeDNSRecord´ and use dedicated HaveTTL which allows to use also "<=" comparison and make TTL assertion optional (without "hack" with 0 TTL before)

• some small improvement on "Eventually" calls

After removing of sleep in a test, a race condition in cache is occurred. This was also fixed by a separate commit.

[codecov]

Codecov Report

Base: 93.32% // Head: 93.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (a7a6d44) compared to base (9abeaed).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff              @@
##           development     #798   +/-   ##
============================================
  Coverage        93.32%   93.33%           
============================================
  Files               42       42           
  Lines             4841     4845    +4     
============================================
+ Hits              4518     4522    +4     
  Misses             255      255           
  Partials            68       68           

Impacted Files	Coverage Δ
resolver/blocking_resolver.go	98.14% <100.00%> (ø)
resolver/caching_resolver.go	97.88% <100.00%> (+0.04%)	⬆️
resolver/fqdn_only_resolver.go	100.00% <100.00%> (ø)
resolver/hosts_file_resolver.go	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[0xERR0R]

rebased on latest development branch

[kwitsch]

I really like how SatisfyAll makes the unit tests way more readable.

dns.Type constants 👍
defer ➡ DeferCleanup 👍