Skip to content

chore(test): fix freezing test #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2023
Merged

chore(test): fix freezing test #932

merged 1 commit into from
Mar 15, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Mar 15, 2023

On my local machine and on a code server instance the execution of resolver tests was frozen. After some debugging, I found that the "system resolver" in the test was invoked > 15 times and the channel has only capacity of 10.

@0xERR0R 0xERR0R added this to the v0.21 milestone Mar 15, 2023
@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (2e0b6e4) 92.83% compared to head (5661c7d) 92.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   92.83%   92.91%   +0.07%     
==========================================
  Files          63       63              
  Lines        5389     5389              
==========================================
+ Hits         5003     5007       +4     
+ Misses        312      309       -3     
+ Partials       74       73       -1     
Impacted Files Coverage Δ
config/config.go 76.49% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xERR0R 0xERR0R merged commit db1e2fd into main Mar 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-bootstrap-test branch March 15, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants