Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): use v prefixed release versions (#858, #806) #942

Merged
merged 1 commit into from
Mar 26, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Mar 21, 2023

@0xERR0R 0xERR0R added 📙 documentation Improvements or additions to documentation 🧰 technical debts Technical debts, refactoring labels Mar 21, 2023
@0xERR0R 0xERR0R added this to the v0.21 milestone Mar 21, 2023
@0xERR0R 0xERR0R linked an issue Mar 21, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (ebe3805) 93.53% compared to head (65e79aa) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   93.53%   93.60%   +0.07%     
==========================================
  Files          61       61              
  Lines        5258     5258              
==========================================
+ Hits         4918     4922       +4     
+ Misses        266      263       -3     
+ Partials       74       73       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xERR0R 0xERR0R requested a review from ThinkChaos March 24, 2023 06:41
Copy link
Collaborator

@ThinkChaos ThinkChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't approve initially cause I don't have experience with the tool, but looks sensible :)

@0xERR0R 0xERR0R merged commit a37861b into main Mar 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the version_number_goreleaser branch March 26, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📙 documentation Improvements or additions to documentation 🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix release naming to match tags for downloads Link to API documentation in HTTP Server root is broken
3 participants