Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions Update #951

Merged
merged 8 commits into from
Mar 28, 2023
Merged

GitHub Actions Update #951

merged 8 commits into from
Mar 28, 2023

Conversation

kwitsch
Copy link
Collaborator

@kwitsch kwitsch commented Mar 24, 2023

Changes:

  • makefile.yml: magnetikonline/action-golang-cache@v4 to actions/setup-go@v4 (setup-go v4 has caching enabled by default)
  • development-docker.yml: enabled for fb-* branches
  • development-docker.yml: only add development tag if branch is main
  • codeql-analysis.yml: added actions/setup-go@v4 for caching
  • codeql-analysis.yml: removed single element matrix
  • codeql-analysis.yml: changed Autobuild to make release to guarantee actual build output

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (c74a277) 93.55% compared to head (82b51b1) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   93.55%   93.60%   +0.05%     
==========================================
  Files          61       61              
  Lines        5258     5258              
==========================================
+ Hits         4919     4922       +3     
+ Misses        265      263       -2     
+ Partials       74       73       -1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xERR0R
Copy link
Owner

0xERR0R commented Mar 27, 2023

I removed docker deployment for "fb-*" branches last time. I don't really used it and there were a lot of staled tags in docker hub/ghcr. If you use fb docker deployments, we can add it again. Maybe you have some ideas, if it is possible to delete fb docker images automatically after some period?

@0xERR0R 0xERR0R added the 🧰 technical debts Technical debts, refactoring label Mar 27, 2023
@0xERR0R 0xERR0R added this to the v0.22 milestone Mar 27, 2023
@kwitsch
Copy link
Collaborator Author

kwitsch commented Mar 27, 2023

I actually often used this feature on my fork. 😅

If you don't use it we could change the branch match to something else and only push it to ghcr.

I'm currently testing some actions to automatically synchronize and cleanup my fork.
I'll add the registry cleanup to the tasks.

@0xERR0R
Copy link
Owner

0xERR0R commented Mar 27, 2023

If you don't use it we could change the branch match to something else and only push it to ghcr.

No, it's ok, we can leave it, since it is sometime quite useful to have a docker image for a particular feature. Cleanup task would be nice, we can also do it later in a separate PR.

@kwitsch kwitsch merged commit 2496c36 into 0xERR0R:main Mar 28, 2023
@kwitsch kwitsch deleted the fb-gh_actions-change branch March 28, 2023 09:43
@kwitsch kwitsch mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧰 technical debts Technical debts, refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants