customDns: add cname support

[SuperSandro2000]

related #465

[codecov]

Codecov Report

Patch coverage: 45.00% and project coverage change: -0.21 ⚠️

Comparison is base (f204809) 93.55% compared to head (b29770b) 93.34%.

❗ Current head b29770b differs from pull request most recent head cfab1cc. Consider uploading reports for the commit cfab1cc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   93.55%   93.34%   -0.21%     
==========================================
  Files          63       63              
  Lines        5323     5337      +14     
==========================================
+ Hits         4980     4982       +2     
- Misses        268      278      +10     
- Partials       75       77       +2     

Impacted Files	Coverage Δ
resolver/custom_dns_resolver.go	89.10% <45.00%> (-10.90%)	⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jkossis]

Is there an ETA on this by any chance?

[0xERR0R]

Thanks for your contribution and sorry for delay, I had a lot to do at work and little time for private projects.

I tried your change and it works: for each rewrite entry a CNAME DNS response will be returned. I testet also with following config (from documentation):

customDNS:
  customTTL: 1h
  filterUnmappedTypes: true
  rewrite:
    home: lan
    replace-me.com: with-this.com
  mapping:
    printer.lan: 192.168.178.3
    otherdevice.lan: 192.168.178.15,2001:0db8:85a3:08d3:1319:8a2e:0370:7344

DNS questions for "printer.lan" or "printer.home" return A 192.168.178.3, because the "home" part will be rewritten to "lan". But I'll also receive CNAME record for "home". It is desired? I think, using of "rewrite" section for query rewrite and CNAME records is a bit confusing, just IMHO.

Maybe we should do it more explicitly, for example:

customDNS:
  ...
  mapping:
    printer.lan: A(192.168.178.3)
    some.domain: CNAME(example.com)
    other.domain: TXT(blabla)

With support for A/AAAA (default), CNAME, TXT, MX, ...?

[SuperSandro2000]

I am not planning to work more on this currently.

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

This PR was closed because it has been stalled for 10 days with no activity.