Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Correct stream conf #445

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Bugfix/Correct stream conf #445

merged 1 commit into from
Jul 22, 2024

Conversation

PeterWang-dev
Copy link
Contributor

Fix #444

@0xJacky 0xJacky self-requested a review July 22, 2024 00:27
@0xJacky 0xJacky merged commit da682cc into 0xJacky:dev Jul 22, 2024
@0xJacky
Copy link
Owner

0xJacky commented Jul 22, 2024

Thanks for your contribution. 🎉

@PeterWang-dev
Copy link
Contributor Author

@0xJacky By the way, maybe you should announce user to update there nginx.conf as it is only generated on first run.

@PeterWang-dev
Copy link
Contributor Author

I think maybe hide nginx.conf and boundle it with Docker image is more reasonable, that is, seperate nginx-ui generated config with nginx innner conf and adapt nginx.conf to read the files.

@PeterWang-dev
Copy link
Contributor Author

I think maybe hide nginx.conf and boundle it with Docker image is more reasonable, that is, seperate nginx-ui generated config with nginx innner conf and adapt nginx.conf to read the files.

However that may bring defects for those hardened user wanna customize nginx. That's a trade-off of design. Up to you.

@0xJacky
Copy link
Owner

0xJacky commented Jul 22, 2024

We’re planning to introduce a validator for nginx.conf to tackle these issues.

Forcing an override of nginx.conf can be very disruptive. Using a combination of a validator and a fixer might make the migration process much smoother.

https://github.com/users/0xJacky/projects/1/views/1?pane=issue&itemId=27245100

@PeterWang-dev
Copy link
Contributor Author

We’re planning to introduce a validator for nginx.conf to tackle these issues.

Forcing an override of nginx.conf can be very disruptive. Using a combination of a validator and a fixer might make the migration process much smoother.

https://github.com/users/0xJacky/projects/1/views/1?pane=issue&itemId=27245100

Got it. Thanks for your awsome work.

@PeterWang-dev PeterWang-dev deleted the bugfix/correct-stream-conf branch July 23, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary trailing .conf in default nginx stream configuration file
2 participants