This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Fix error caused by querying non-standard ERC20 contracts without Decimal #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error caused by querying non-standard ERC20 contracts without Decimal function
Example: 0xc0ca776fe52eC92b1D5603cAadf148DbD8C22a80
Limit the gas limit of the call, 20000 is already enough for normal contract calls.
The 20000 limit was a random thought, because I tested that 5000 would affect the normal token lookup, so I set it a bit bigger.
However, I don't understand why you don't use try catch, maybe it's better that way, maybe I didn't think about it in some places.