-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reqwest can not use SOCKS proxy #311
base: main
Are you sure you want to change the base?
Conversation
0xPlaygrounds#310 * enable feature of reqwest to support socks proxy
Hey, thanks for this PR! Is there more details you can describe about your use case with SOCK proxies? I could see this being used for an optional feature or a default feature based on the use case! |
Inside our datacenter, the servers cannot access the internet directly. Instead, we provide a SOCKS proxy by default because it offers better speed and stability.Maybe you can set it as an optional feature, but it will require a convenient configuration method |
I think the most ideal way to do this would be to add it as a feature since otherwise, it'll be a breaking change and it would be ideal to keep core dependencies low. |
hi @0xMochan , when will you merge this contribute to the project |
Hi, Mochan's currently OOO at the moment. If you can set up the socks feature as a separate feature for |
cf2446c
to
21f01ed
Compare
@joshua-mo-143 pls check now |
#310