Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove syncers and import the aggkit #256

Merged
merged 18 commits into from
Feb 18, 2025
Merged

feat: remove syncers and import the aggkit #256

merged 18 commits into from
Feb 18, 2025

Conversation

rachit77
Copy link
Contributor

@rachit77 rachit77 commented Jan 7, 2025 •
edited by Stefan-Ethernal
Loading

Description

This PR removes syncers (bridge syncer, last ger syncer, claim sponsor), bridge service, and other relevant packages for aggkit repo migration.

@rachit77 rachit77 changed the title Removes syncers for aggkit migration feat: removes syncers for aggkit migration Jan 7, 2025
@rachit77 rachit77 marked this pull request as draft January 7, 2025 13:22
@rachit77 rachit77 self-assigned this Jan 10, 2025
@rachit77 rachit77 marked this pull request as ready for review January 10, 2025 14:52
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/aggkit-repo-migration branch from 79c94e2 to 04b8363 Compare January 21, 2025 11:37
@Stefan-Ethernal Stefan-Ethernal mentioned this pull request Jan 21, 2025
Merged
3 tasks
@Stefan-Ethernal Stefan-Ethernal force-pushed the rachit77/remove-syncers branch from d814581 to ac8d966 Compare January 27, 2025 10:51
@rachit77 rachit77 requested a review from a team January 28, 2025 14:15
goran-ethernal
goran-ethernal reviewed Feb 3, 2025
View reviewed changes
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/aggkit-repo-migration branch from baa4aaa to 7116e38 Compare February 4, 2025 14:50
@Stefan-Ethernal
Copy link
Collaborator

Should we reuse the following packages from the aggkit as well (and remove it from the cdk):

  • db,
  • etherman (partially),
  • hex,
  • log

Stefan-Ethernal and others added 8 commits February 10, 2025 01:36
@Stefan-Ethernal @rachit77
feat: remove aggoracle component (#251)
3d4be0e 
* remove aggoracle component

* improve Rust build perf and cleanup

* handle error when unmarashaling versions.json
@Stefan-Ethernal @rachit77
feat: remove aggsender component (#252)
5d32d87 
* remove aggsender component

* fix: remove build-tools
@temaniarpit27 @Stefan-Ethernal @rachit77
feat: mockery generate (#255)
5088af4 
* mockery generate

* Update .mockery.yaml

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* review comments

* review comment

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@rachit77
wip
327a72f
@ToniRamirezM @rachit77
feat: fix BuildVersions during cargo build (#258)
6f7fd29
@rachit77
fix DAC imports
800570f
@rachit77
remove unused code
5c8d613
@Stefan-Ethernal @rachit77
chore: remove empty docker-compose.yml
1cd27ec
@rachit77 rachit77 force-pushed the rachit77/remove-syncers branch from 327487e to 1cd27ec Compare February 11, 2025 09:55
@rachit77
Copy link
Contributor Author

rachit77 commented Feb 11, 2025 •
edited
Loading

Should we reuse the following packages from the aggkit as well (and remove it from the cdk):

  • db,
  • etherman (partially),
  • hex,
  • log

Removed db, hex and log. For etherman maybe we need discuss how we want to tackle this

@Stefan-Ethernal
Copy link
Collaborator

Stefan-Ethernal commented Feb 11, 2025 •
edited
Loading

Just to put a reminder here:
we should remove the bridge rpc implementation logic from the CDK (https://github.com/0xPolygon/cdk/blob/327a72f495a7f4ef27138cf58ec629bc8c2e30ac/rpc/bridge.go), but we might want to instantiate the one from the aggkit repository (TBD). The same applies to the aggsender component.

@Stefan-Ethernal Stefan-Ethernal changed the title feat: removes syncers for aggkit migration feat: remove syncers for aggkit migration Feb 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Stefan-Ethernal Stefan-Ethernal changed the title feat: remove syncers for aggkit migration feat: remove syncers and import the aggkit Feb 14, 2025
@Stefan-Ethernal Stefan-Ethernal merged commit aed13f5 into feat/aggkit-repo-migration Feb 18, 2025
12 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the rachit77/remove-syncers branch February 18, 2025 08:51
Stefan-Ethernal added a commit that referenced this pull request Feb 18, 2025
@rachit77 @Stefan-Ethernal
@temaniarpit27 @ToniRamirezM
feat: remove syncers and import the aggkit (#256)
bad184a 
* feat: remove `aggoracle` component (#251)

* remove aggoracle component

* improve Rust build perf and cleanup

* handle error when unmarashaling versions.json

* feat: remove `aggsender` component (#252)

* remove aggsender component

* fix: remove build-tools

* feat: mockery generate (#255)

* mockery generate

* Update .mockery.yaml

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* review comments

* review comment

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* wip

* feat: fix BuildVersions during cargo build (#258)

* fix DAC imports

* remove unused code

* chore: remove empty docker-compose.yml

* fix build.rs

* remove hex package

* remove log package

* remove db package

* go mod tidy and fix in the proof

* chore: remove redundant file

* feat: remove bridge service (feat. claim sponsor, bridgesync, reorg detector l2 and corresponding config params)

* chore: format and fix docs

* chore: move bats e2e tests from fep folder

* fix: path for batch_verification_monitor script

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Arpit Temani <temaniarpit27@gmail.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>
Stefan-Ethernal added a commit that referenced this pull request Feb 18, 2025
@Stefan-Ethernal @temaniarpit27
@rachit77 @ToniRamirezM
feat: aggkit repo migration (#253)
15f95ce 
* feat: remove `aggoracle` component (#251)

* remove aggoracle component

* improve Rust build perf and cleanup

* handle error when unmarashaling versions.json

* feat: remove `aggsender` component (#252)

* remove aggsender component

* fix: remove build-tools

* fix: improve JSON parsing by cleaning up version strings

* feat: mockery generate (#255)

* mockery generate

* Update .mockery.yaml

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* review comments

* review comment

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* rebase fix

* feat: remove syncers and import the aggkit (#256)

* feat: remove `aggoracle` component (#251)

* remove aggoracle component

* improve Rust build perf and cleanup

* handle error when unmarashaling versions.json

* feat: remove `aggsender` component (#252)

* remove aggsender component

* fix: remove build-tools

* feat: mockery generate (#255)

* mockery generate

* Update .mockery.yaml

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* review comments

* review comment

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>

* wip

* feat: fix BuildVersions during cargo build (#258)

* fix DAC imports

* remove unused code

* chore: remove empty docker-compose.yml

* fix build.rs

* remove hex package

* remove log package

* remove db package

* go mod tidy and fix in the proof

* chore: remove redundant file

* feat: remove bridge service (feat. claim sponsor, bridgesync, reorg detector l2 and corresponding config params)

* chore: format and fix docs

* chore: move bats e2e tests from fep folder

* fix: path for batch_verification_monitor script

---------

Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Arpit Temani <temaniarpit27@gmail.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <stefan@ethernal.tech>

---------

Co-authored-by: Arpit Temani <temaniarpit27@gmail.com>
Co-authored-by: Rachit Sonthalia <54906134+rachit77@users.noreply.github.com>
Co-authored-by: Toni Ramírez <58293609+ToniRamirezM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@ToniRamirezM ToniRamirezM ToniRamirezM approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@rachit77 rachit77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rachit77 @Stefan-Ethernal @vcastellm @ToniRamirezM @goran-ethernal @temaniarpit27