Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: docker hub login #312

Merged
merged 10 commits into from
Oct 22, 2024
Merged

ci: docker hub login #312

merged 10 commits into from
Oct 22, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Oct 15, 2024

Description

  • Create a new user and PAT for docker hub and save the credentials under the Kurtosis CDK CI note in 1Password.
  • Create two secrets in this Github repository: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN.
  • Login to Docker Hub before any kurtosis run command if secrets are defined. This way we can also enable back the security build on PRs - it won't fail for forks anymore!

References (if applicable)

@leovct leovct force-pushed the ci/docker-hub-login branch from 12f6786 to 987d6c5 Compare October 15, 2024 11:03
@leovct leovct changed the title ci: docker hub login ci: log in to the docker hub when possible Oct 21, 2024
@leovct leovct marked this pull request as ready for review October 21, 2024 09:36
@leovct leovct requested a review from a team October 21, 2024 09:36
@leovct leovct enabled auto-merge (squash) October 21, 2024 16:34
@leovct leovct changed the title ci: log in to the docker hub when possible ci: docker hub login Oct 21, 2024
@leovct leovct merged commit 38a979a into 0xPolygon:main Oct 22, 2024
15 checks passed
@leovct leovct deleted the ci/docker-hub-login branch October 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants