Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for normalcy/cancun flags #353

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Adding support for normalcy/cancun flags #353

merged 6 commits into from
Nov 5, 2024

Conversation

praetoriansentry
Copy link
Member

Description

Adding some support to run with the normalcy flag. This should align somewhat with the goals of testing the pessimistic proof setup as well.

Currently I'm testing with:

kurtosis run --enclave cdk . '{"args": {"enable_normalcy": true, "cdk_erigon_node_image": "hermeznetwork/cdk-erigon:v2.60.0-beta2", "erigon_strict_mode": false}}'

@praetoriansentry praetoriansentry marked this pull request as ready for review November 4, 2024 23:30
@praetoriansentry
Copy link
Member Author

fyi @Nashtare

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cffls
cffls approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

jhkimqd
jhkimqd approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@jhkimqd jhkimqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

@praetoriansentry praetoriansentry merged commit d0883d7 into main Nov 5, 2024
24 checks passed
@praetoriansentry praetoriansentry deleted the jhilliard/normalcy-flag branch November 5, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhkimqd jhkimqd jhkimqd approved these changes

@cffls cffls cffls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praetoriansentry @cffls @jhkimqd