test: add attaching a third PP network into the CI #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
|
This would ideally integrate SP1 prover keys with Github secrets. I think we can follow up after we get a test key for CI purposes. |
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
e30077f to
11440e8
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
11440e8 to
f1a72c3
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
…rst rollup. Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
c43b33d to
1ff098c
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
|
At this point, we're waiting for the fix + new agglayer/cdk images. Once they come, we can rerun the checks and hopefully get this merged asap! |
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
d3bd6b2 to
2552e5f
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
e4cd243 to
d76c7f9
Compare
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
8580cbc to
0cfb6d8
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
jhkimqd
force-pushed
the
jihwan/pp-workflow
branch
from
0cfb6d8 to
d2479ab
Compare
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Signed-off-by: Ji Hwan <jkim@polygon.technology>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds another step to attach a third PP network in addition to the existing steps, and does a minimal check by sending a simple transfer in that network. The test CI seems to be passing.
This is however dependent on using the PP CDK Erigon and Contract images, so it may be better to hold until the latest images are applied on the
mainbranch first: