Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin foundry version in ci and docker images #405

Closed
wants to merge 4 commits into from

Conversation

leovct
Copy link
Member

@leovct leovct commented Nov 28, 2024

Description

Prevent a foundry breaking change from breaking our package.

  • All the zkevm-contracts images have been rebuilt using the latest foundry nightly version.
  • A new toolbox image tag has been released: 0.0.7 containing the latest foundry nightly version also.

References (if applicable)

@leovct leovct marked this pull request as ready for review November 28, 2024 16:01
@leovct leovct requested a review from a team November 28, 2024 16:01
@leovct leovct marked this pull request as draft November 29, 2024 08:46
@leovct
Copy link
Member Author

leovct commented Nov 29, 2024

I realised this All the zkevm-contracts images have been rebuilt using the latest foundry nightly version created a big mess!!! I'm gonna undo this change so that the older versions of the package work and gonna release new images with the new foundry version...

edit: zkevm-contracts have been reset with the older foundry version, it's working again.

@leovct leovct closed this Nov 29, 2024
@leovct leovct deleted the chore/pin-foundry-version branch November 29, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant