Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix foundryup error #432

Closed
wants to merge 2 commits into from
Closed

fix foundryup error #432

wants to merge 2 commits into from

Conversation

doutv
Copy link

@doutv doutv commented Dec 31, 2024 •
edited
Loading

Fix #431

@doutv doutv mentioned this pull request Dec 31, 2024
Closed
leovct
leovct approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@leovct leovct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx!

edit 1: you might need to sign your commit, otherwise I can't merge your PR :s
edit 2: can you also fix the toolbox img?

docker/zkevm-contracts.Dockerfile Outdated Show resolved Hide resolved
@leovct leovct enabled auto-merge (squash) December 31, 2024 09:01
@doutv
Copy link
Author

doutv commented Dec 31, 2024

Oh, you can create a new PR to fix it. I don't have time to edit...

@leovct
Copy link
Member

leovct commented Dec 31, 2024

Closing this PR in favour of #433

@leovct leovct closed this Dec 31, 2024
auto-merge was automatically disabled December 31, 2024 13:08

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovct leovct leovct approved these changes

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry praetoriansentry is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build zkevm-contract docker image fail
2 participants
@doutv @leovct