-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhance management of custom docker images #91
Merged
leovct
merged 40 commits into
main
from
chore/enhance-management-of-custom-docker-images
Apr 29, 2024
Merged
feat: enhance management of custom docker images #91
leovct
merged 40 commits into
main
from
chore/enhance-management-of-custom-docker-images
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
praetoriansentry
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we manage three custom Docker images for deploying the CDK stack: one housing various zkevm contracts (each fork tagged separately), another adapting the bridge UI to accommodate relative URLs, and a third for applying workloads.
The aim is to:
=> For the moment, images are still hosted on the Docker Hub under my username. That's fine for now.
https://hub.docker.com/u/leovct
Other
npm install
random fails with ECONNRESET and ETIMEDOUT by upgradingnpm
to a version higher or equal to 10.5.1 (see the fix: fix: ensure maxSockets is respected npm/cli#7324)hadolint
check in CI.Dockerfile
files.References (if applicable)
https://polygon.atlassian.net/browse/DVT-1467
Test
I enabled the CI to run on this PR. I'll remove it once we've tested that we can build and successfully send images to our GCR.
Jobs are progressing and images are being built.