Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance management of custom docker images #91

Merged
merged 40 commits into from
Apr 29, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Apr 26, 2024

Description

Currently, we manage three custom Docker images for deploying the CDK stack: one housing various zkevm contracts (each fork tagged separately), another adapting the bridge UI to accommodate relative URLs, and a third for applying workloads.

The aim is to:

  • 1. Streamline the organization of our Dockerfiles and forks.
  • 2. Establish a daily or weekly cron job for building and pushing these images.
  • 3. Transition the hosting of these images from DockerHub to GCR.
    => For the moment, images are still hosted on the Docker Hub under my username. That's fine for now.
    https://hub.docker.com/u/leovct
    Screenshot 2024-04-29 at 16 22 49

Other

References (if applicable)

https://polygon.atlassian.net/browse/DVT-1467

Test

I enabled the CI to run on this PR. I'll remove it once we've tested that we can build and successfully send images to our GCR.

---
name: Docker Image Builder Cron


on:
  schedule:
    - cron: '0 6 * * 1'  # Every Monday at 6 AM Paris time (UTC+2).
  workflow_dispatch:
  pull_request: # TODO: Remove this. This is just for testing purposes.

...

Jobs are progressing and images are being built.

Screenshot 2024-04-26 at 12 20 31

@leovct leovct marked this pull request as ready for review April 29, 2024 14:21
@leovct leovct requested a review from a team April 29, 2024 14:24
Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@leovct leovct merged commit 4ed4953 into main Apr 29, 2024
14 of 16 checks passed
@leovct leovct deleted the chore/enhance-management-of-custom-docker-images branch April 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants