Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sensor fix: accurately timestamp data on arrival #418

Merged
merged 3 commits into from
Oct 31, 2024
Merged

sensor fix: accurately timestamp data on arrival #418

merged 3 commits into from
Oct 31, 2024

Conversation

rebelArtists
Copy link
Contributor

Description

timestamp data collected immediately at arrival, not after goroutine has been spawned downstream

Testing

smoke tests:

  • sensors run locally with timestamp changes: no errors running program
  • still unclear how to test event writing locally (to ensure data results clean)

@minhd-vu minhd-vu marked this pull request as ready for review October 31, 2024 14:51
@minhd-vu minhd-vu merged commit efea2e2 into main Oct 31, 2024
6 checks passed
@minhd-vu minhd-vu deleted the dan/timestamp_event_fix branch October 31, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhd-vu minhd-vu minhd-vu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebelArtists @minhd-vu