-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AcceptState
not timing out to RoundChangeState
#243
Comments
Hey @mrwillis, thank you for reaching out! I have investigated this issue and concluded the following:
To summarize, I haven’t found any problems in the code logic for the "accept state" regarding the situation you experienced. |
@brkomir thanks for looking into this. I just checked on 3. and yes as there wasn't debug logging available, it's possible they were cycling between the states. We were 100% confident that at the time that all the nodes were up and running, so we do believe there is an issue somewhere. Then it is possible the logs were the same under the hood as in #248. Added logging would be great to see the state changes at the INFO level. We can close this for now. |
AcceptState
not timing out toRoundChangeState
Description
When debugging our latest testnet crash (#235 and #232), we noticed a lot of the nodes got stuck in AcceptState, unable to get pushed out to RoundChangeState. So essentially we had a bunch of nodes in RoundChangeState, waiting for others to get into RoundChangeState, and some nodes in AcceptState unable to get booted to RoundChangeState.
We're not quite sure how or why this happens yet.
Unless I'm missing something, in
runAcceptState
, it looks like the only way this can happen is ifgetNextMessage
continues to return afalse
value in the second parameter.Your environment
Steps to reproduce
Expected behaviour
After timing out, it should get pushed to
RoundChangeState
according to the specActual behaviour
Nodes get stuck in AcceptState in an exponentially-increasing timeout loop.
Logs
The text was updated successfully, but these errors were encountered: