Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Upgrade libp2p and fix dropped message issue in gossip #312

Merged
merged 3 commits into from
Dec 27, 2021
Merged

Upgrade libp2p and fix dropped message issue in gossip #312

merged 3 commits into from
Dec 27, 2021

Conversation

Kourin1996
Copy link
Contributor

@Kourin1996 Kourin1996 commented Dec 24, 2021 •
edited
Loading

Description

This PR upgrades packages around libp2p to fix the follwing issues:

(1) Fix handshake issue in libp2p described in libp2p/go-libp2p-noise#70
(2) Set buffer size in pubsub to avoid dropped messages in gossip. There was possibility of that messages are dropped when internal queue is full.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Kourin1996 Kourin1996 self-assigned this Dec 24, 2021
@zivkovicmilos zivkovicmilos mentioned this pull request Dec 25, 2021
Merged
8 tasks
zivkovicmilos
zivkovicmilos approved these changes Dec 26, 2021
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Thank you for updating the libp2p package to v0.14.0 🙏

@brkomir brkomir marked this pull request as ready for review December 27, 2021 13:26
brkomir
brkomir approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@brkomir brkomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good!

@Kourin1996 Kourin1996 changed the title Fix dropped message issue in gossip Upgrade libp2p and fix dropped message issue in gossip Dec 27, 2021
lazartravica
lazartravica approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@lazartravica lazartravica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the linked libp2p issue

@Kourin1996 Kourin1996 merged commit 9a6905a into develop Dec 27, 2021
@Kourin1996 Kourin1996 deleted the fix/lost-gossip-messages branch December 27, 2021 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brkomir brkomir brkomir approved these changes

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@lazartravica lazartravica lazartravica approved these changes

Assignees

@Kourin1996 Kourin1996

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kourin1996 @lazartravica @zivkovicmilos @brkomir