This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Fix secrets generate issues when the type is aws-ssm #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed mandatory flags from secrets cmd ( only name required ) * fixed Extra field issue * added timeout 2min. to linter
ZeljkoBenovic
requested review from
zivkovicmilos,
lazartravica and
Kourin1996
as code owners
zivkovicmilos
approved these changes
Apr 13, 2022
Kourin1996
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues that were overlooked in CLI refactor.
It fixes the issue with
secrets generatecommand when the type isaws-ssm.Removes some required flags, as they already have default values.
Fixes the
Extra:field inSecretsManagerConfig, which was initialized with nil.Changes include
Checklist
Testing
Manual tests
Generate secretsManagerConfig.json file by running
go run . secrets generate --type aws-ssm --extra region=eu-central-1,ssm-parameter-path=/polygon-edge/nodes --name node1and use the file to store init secrets in AWS SSM
go run . secrets init --config secretsManagerConfig.jsonConfirmed working by inspecting AWS SSM in web console.