This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 535
Add support for better client version details #672
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
requested review from
lazartravica,
Kourin1996,
dbrajovic and
0xAleksaOpacic
as code owners
August 5, 2022 10:04
ZeljkoBenovic
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good.
We should just consider if we're totally removing GET endpoint
Codecov Report
@@ Coverage Diff @@
## develop #672 +/- ##
===========================================
- Coverage 52.70% 52.56% -0.14%
===========================================
Files 130 130
Lines 17146 17111 -35
===========================================
- Hits 9037 8995 -42
- Misses 7461 7470 +9
+ Partials 648 646 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kourin1996
approved these changes
Sep 21, 2022
0xAleksaOpacic
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for exelent tests coverage 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a pending issue that doesn't return proper chain information on the client version.
It removes the base
GET
endpoint to the JSON-RPC layer, as it's not by the standard, nor should it be supported.Users should use the
web3_clientVersion
endpoint instead, that is outlined in the specification.Changes include
Checklist
Testing
Additional comments
Fix EDGE-709