Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

EVM-25 Create state abstraction boundaries for write-ops in the state… #753

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented Sep 22, 2022

Description

State Transition Function should not call Commit from the Snapshot interface and should only return the entries in the state that have been updated. Then, as part of another workflow, these entries would be updated in the merkle trie.
Jira Task Link

Changes include

  • New feature (non-breaking change that adds functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels

Testing

  • I have tested this code with the official test suite

@igorcrevar igorcrevar added the feature New update to Polygon Edge label Sep 22, 2022
@igorcrevar igorcrevar self-assigned this Sep 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 22, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@igorcrevar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #753 (b7ef727) into develop (c39d854) will decrease coverage by 0.03%.
The diff coverage is 8.69%.

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    52.51%   52.48%   -0.04%     
===========================================
  Files          130      130              
  Lines        17069    17072       +3     
===========================================
- Hits          8964     8960       -4     
- Misses        7462     7468       +6     
- Partials       643      644       +1     
Impacted Files Coverage Δ
state/executor.go 3.93% <0.00%> (-0.03%) ⬇️
state/testing.go 0.00% <0.00%> (ø)
state/txn.go 19.85% <0.00%> (+0.09%) ⬆️
tests/testing.go 69.44% <100.00%> (+0.10%) ⬆️
network/server_discovery.go 73.88% <0.00%> (-1.92%) ⬇️
network/server.go 75.75% <0.00%> (-0.43%) ⬇️
chain/chain_bindata.go 32.31% <0.00%> (ø)
network/e2e_testing.go 63.89% <0.00%> (ø)
secrets/local/local.go 75.70% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

state/testing.go Outdated Show resolved Hide resolved
@ferranbt ferranbt merged commit aa8b3fe into develop Sep 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2022
@zivkovicmilos zivkovicmilos deleted the EVM-23_EVM-25 branch October 11, 2022 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants