This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 535
EVM-25 Create state abstraction boundaries for write-ops in the state… #753
Merged
+27
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
requested review from
Kourin1996,
dbrajovic and
0xAleksaOpacic
as code owners
September 22, 2022 09:26
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## develop #753 +/- ##
===========================================
- Coverage 52.51% 52.48% -0.04%
===========================================
Files 130 130
Lines 17069 17072 +3
===========================================
- Hits 8964 8960 -4
- Misses 7462 7468 +6
- Partials 643 644 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dbrajovic
approved these changes
Sep 22, 2022
ferranbt
reviewed
Sep 22, 2022
Kourin1996
approved these changes
Sep 26, 2022
ferranbt
approved these changes
Sep 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
State Transition Function
should not callCommit
from theSnapshot
interface and should only return the entries in the state that have been updated. Then, as part of another workflow, these entries would be updated in themerkle trie
.Jira Task Link
Changes include
Checklist
Testing