Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Rename difficulty to totalDifficulty #201

Merged
merged 2 commits into from
Nov 8, 2021
Merged

Rename difficulty to totalDifficulty #201

merged 2 commits into from
Nov 8, 2021

Conversation

dbrajovic
Copy link
Contributor

@dbrajovic dbrajovic commented Nov 8, 2021 •
edited
Loading

Description

Change varaible names and function calls where totalDifficulty is meant by difficulty

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@dbrajovic dbrajovic self-assigned this Nov 8, 2021
zivkovicmilos
zivkovicmilos approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

Thank you for improving the readability on this 🙏

Kourin1996
Kourin1996 approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@Kourin1996 Kourin1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's become more clear 🤗

@lazartravica lazartravica requested a review from brkomir November 8, 2021 11:49
brkomir
brkomir approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@brkomir brkomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left one comment but apart form that everything looks ok to me.

blockchain/blockchain.go Outdated Show resolved Hide resolved
@dbrajovic dbrajovic merged commit ce793fa into develop Nov 8, 2021
@dbrajovic dbrajovic deleted the fix/difficulty_renaming branch November 15, 2021 12:48
@dbrajovic dbrajovic mentioned this pull request Nov 18, 2021
Closed
8 tasks
@Kourin1996 Kourin1996 mentioned this pull request Mar 23, 2022
Closed
16 tasks
igorcrevar pushed a commit that referenced this pull request Jun 12, 2023
@everestcw
add JSON RPC parameter like on http transport (#201)
c1d8327
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brkomir brkomir brkomir approved these changes

@Kourin1996 Kourin1996 Kourin1996 approved these changes

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

@lazartravica lazartravica lazartravica approved these changes

@Vuksan Vuksan Awaiting requested review from Vuksan

@munna0908 munna0908 Awaiting requested review from munna0908

@0xpanoramix 0xpanoramix Awaiting requested review from 0xpanoramix

Assignees

@dbrajovic dbrajovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dbrajovic @lazartravica @zivkovicmilos @Kourin1996 @brkomir