This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
[IBFT] Block difficulty is one #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrajovic
requested review from
lazartravica,
Vuksan and
zivkovicmilos
as code owners
dbrajovic
requested review from
brkomir,
Kourin1996,
munna0908 and
0xpanoramix
zivkovicmilos
approved these changes
Nov 20, 2021
Kourin1996
approved these changes
Nov 22, 2021
brkomir
approved these changes
Nov 23, 2021
lazartravica
added
the
don't merge
|
hi @dbrajovic @lazartravica, will this be added as a flag or something like --ibft-difficulty in |
The original idea was just conforming to the spec - no additional benefits other than that. If this gets released after the point the chain cannot be reset for you, we'll probably include a forks-in-time support |
|
Closing and archiving under |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally starting as the idea in (now closed) PR#182, this PR is the third (and final) part of the series, addressing the block difficulty in IBFT. The first two being PR#201 and PR#208.
Essentially, it conforms to the standard described in the original IBFT consensus
Changes include
Breaking changes
The breaking change is introduced here.
A previously running node restarted with this build might still be able to produce blocks, but the danger of it failing to verify headers (during bulk sync) at some point is never absent.
Newly added nodes to the cluster will not be able to move past genesis and can never sync with the chain.
Checklist