fix: delete retry requests if confirmed or sent #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a rare condition where some transactions' status changes (possibly due to network issues) and causes a memory leak in the pool-manager which was causing the system to crash. Although a restart of the pool-manager fixed the issue, after applying the changes in this PR, the same issue could no longer be reproduced.
Testing
The entire test had been conducted using Kurtosis CDK and loads were sent using
polycli loadtest
, usinghermeznetwork/zkevm-pool-manager:v0.1.0
When sending moderate load (10,000 EOA transfers) to the CDK Erigon RPC node, it directs the transactions to the pool manager. The loadtest also involved
429
codes returned by the Erigon RPC, and had some transactions which had unexpectedstatus
values in thepool_manager_db
These were not mined - until a replacement transaction has been sent with higher gas prices.
This seemed to cause the pool-manager to detect these transactions and attempt to delete and enqueue them again - which seemed to be the source of the leak.
With this PR, the issue could no longer be reproduced under identical conditions.