fix: change return value of ListContentAtACL and write test for it #1373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few important changes to the ListContentAtACL function:
ListContentAtACL
was dynamic, and there were756
unique combinations for the output (5, 2, 2). The nature of the db query could not be changed, but to make this much more predictable and testable, the previous return value has been split into 4 different strings - all combined to return a[]string
. The slice of strings contains the original output, in addition to three other outputs, separated by the table names:combinedBuffers = append(combinedBuffers, bufferConfig.String())
combinedBuffers = append(combinedBuffers, bufferBlockList.String())
combinedBuffers = append(combinedBuffers, bufferAllowlist.String())
strings.Contains