Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge develop (fork-etrog) to main #80

Merged
merged 41 commits into from
Feb 5, 2024
Merged

merge develop (fork-etrog) to main #80

merged 41 commits into from
Feb 5, 2024
+918 −529

Conversation

zkronos73
Copy link
Contributor

@zkronos73 zkronos73 commented Feb 5, 2024 •
edited
Loading

  • add SHA-256 support with commands HASHS, HASHS1, HASHSLEN, HASHSDIGEST and CNT_SHA256_F counter.
  • add support to array sugar syntax for variables, also for access from commands.
  • add specific arithmethics for FP2: ARITH_BN254_ADDFP2,ARITH_BN254_SUBFP2,ARITH_BN254_MULFP2.
  • add feature to limitate FREE INPUT to one field FREE0.
  • add more options to hashId: register RR as E register, this two indirections could be use an static offset.

zkronos73 and others added 30 commits April 21, 2023 15:51
@zkronos73
add ARITH_FP_CMUL operation
80e0d7a
@zkronos73
change new arith instruction tag to ARITH_BN254_MULFP2
1353c66
@zkronos73
add instruction ARITH_BN254_ADDFP2
3b88efb
@hecmas
Add instruction ARITH_BN254_SUBFP2
dc4bdef
@hecmas
Minor fix
1356cec
@hecmas
Merge pull request #61 from 0xPolygonHermez/feature/pairings-complex-…
9784935 
…addition

Complex addition and complex subtraction added
@zkronos73
add array access on command mem
3e28c7f
@zkronos73
Merge pull request #62 from 0xPolygonHermez/feature/command-arrays
4fd8674 
add array access on command mem
@zkronos73
add module addr to get address on command
a0e7606
@zkronos73
add constant indirection on arrays and indirect on command
fe39b44
@zkronos73
Merge pull request #63 from 0xPolygonHermez/feature/addr-command
324aa6a 
adding constant offset to arrays, same for commands and syntax sugar for it
@krlosMata
useCTX in mem vars
4a097e2
@zkronos73
Merge pull request #64 from 0xPolygonHermez/feature/use-ctx-mem
13525c8 
useCTX in mem vars
@zkronos73
Merge pull request #65 from 0xPolygonHermez/feature/addr-command
5ef8327 
feature/addr command with context support
@zkronos73
Merge pull request #66 from 0xPolygonHermez/feature/pairings
a74737c 
feature/pairings
@krlosMata
all 'num' to strings
7f40fc8
@zkronos73
Merge pull request #68 from 0xPolygonHermez/feature/fix-num
f7ccfe8 
'num' is used on commands for constants and its domain is a "bigint", in json must be a string.
@jbaylina @laisolizq
Add sha256 instructions
f1bc1e4
@laisolizq
fix CNT_SHA256_F
42a214a
@zkronos73
Merge pull request #69 from 0xPolygonHermez/feature/sha256-fix-cnt
96d93ff 
fix CNT_SHA256_F
@zkronos73
add LT4 binary instruction
80d363e
@krlosMata
Merge pull request #70 from 0xPolygonHermez/feature/sha256
b19f652 
Feature/sha256
@zkronos73
Merge branch 'feature/fork-etrog' into feature/lt4
f700eec
@zkronos73
Merge pull request #72 from 0xPolygonHermez/feature/lt4
11e3b2d 
add LT4 binary instruction
@zkronos73
rebuild parser and update instructions document
08fd1cd
@hecmas
Improving the doc
5b297d5
@hecmas
Update components.md
7d822b1
@hecmas
Adding the ability to pass a constant as an array size
7e36e4b
@hecmas
Merge pull request #74 from 0xPolygonHermez/feature/const-in-array-def
52c32cf 
Adding the ability to pass a constant as an array size
@hecmas
Compiler updated (#75)
14097d5
zkronos73 and others added 10 commits November 29, 2023 14:28
@cla-bot cla-bot bot added the cla-signed label Feb 5, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 5, 2024
View reviewed changes
build/zkasm_parser.js Dismissed Show resolved Hide resolved
build/zkasm_parser.js Dismissed Show dismissed Hide dismissed
@zkronos73 zkronos73 marked this pull request as ready for review February 5, 2024 14:03
@zkronos73 zkronos73 requested review from hecmas and krlosMata February 5, 2024 14:03
hecmas
hecmas approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@hecmas hecmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

krlosMata
krlosMata approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@zkronos73 zkronos73 merged commit 042e84f into main Feb 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecmas hecmas hecmas approved these changes

@krlosMata krlosMata krlosMata approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zkronos73 @krlosMata @hecmas @jbaylina @laisolizq