Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR review resolution #123

Merged
merged 3 commits into from
Nov 30, 2023
Merged

PR review resolution #123

merged 3 commits into from
Nov 30, 2023

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Nov 29, 2023 •
edited
Loading

  • PR review
  • Unit testing for blockInfoRoot
  • Moved blockInfotree functions to utils

@cla-bot cla-bot bot added the cla-signed label Nov 29, 2023
@ignasirv ignasirv marked this pull request as draft November 29, 2023 14:51
@ignasirv ignasirv force-pushed the feature/PR-review branch 2 times, most recently from ccb40f1 to 79a4b25 Compare November 30, 2023 09:25
@ignasirv ignasirv marked this pull request as ready for review November 30, 2023 09:44
krlosMata
krlosMata requested changes Nov 30, 2023
View reviewed changes
src/block-utils.js Show resolved Hide resolved
src/block-utils.js
@@ -129,12 +131,45 @@ async function setTxLog(smt, root, txIndex, logIndex, logValue) {
return res.newRoot;
}

async function fillReceiptTree(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing function commments

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

krlosMata
krlosMata approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 57fa389 into feature/fork-etrog Nov 30, 2023
5 checks passed
@ignasirv ignasirv deleted the feature/PR-review branch December 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @krlosMata