Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vc improvement #133

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Feature/vc improvement #133

merged 7 commits into from
Feb 1, 2024

Conversation

ignasirv
Copy link
Contributor

Implement virtual counters manager for etrog

Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

src/processor.js Outdated Show resolved Hide resolved
src/processor.js Show resolved Hide resolved
src/processor.js Outdated Show resolved Hide resolved
src/virtual-counters-manager-utils.js Outdated Show resolved Hide resolved
src/virtual-counters-manager-utils.js Show resolved Hide resolved
src/virtual-counters-manager-utils.js Outdated Show resolved Hide resolved
src/virtual-counters-manager-utils.js Outdated Show resolved Hide resolved
@ignasirv ignasirv force-pushed the feature/vc-improvement branch 2 times, most recently from 12b311c to b4d2f34 Compare January 31, 2024 16:04
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

20 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@krlosMata krlosMata self-requested a review February 1, 2024 14:28
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 8e09d92 into develop Feb 1, 2024
4 checks passed
@ignasirv ignasirv deleted the feature/vc-improvement branch February 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants