Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/v6.3.0 fork.9 #179

Merged
merged 5 commits into from
Aug 2, 2024
Merged

Feature/v6.3.0 fork.9 #179

merged 5 commits into from
Aug 2, 2024

Conversation

ignasirv
Copy link
Contributor

PR to fix som vcounters issues + vcounters improvements:

  • Now at processChangeL2Block the flag verifyMerkleProof is passed to avoid computing the 32 keccaks of the MT
  • New input config at VirtualCountersManager config.steps you can set the steps from config file. Default value 2**23
  • New input config at VirtualCountersManager config.MCPReduction you can reduce the worst case scenario for vPoseidons, the default value is 0.6, we consider 0.6 a safe reduction of the worst case scenario, no OOCP has been detected on production yet.
  • New feature consumptionReport -> for debuggging purposes
  • Fixed bug at opSha3, wrong keccaks computation
  • Fixed bug at _opLog, wrong _opLogLoop calls
  • Reduced steps at _mLoadX, _mstoreX, _mStore32, _mulArith
  • fix poseidon opAnd, opOr, opXor, opNot

Copy link

sonarcloud bot commented Jun 26, 2024

Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@krlosMata krlosMata merged commit 995e016 into develop Aug 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants