[WIP] AggLayer integration #3083

nivida · 2024-01-16T10:29:25Z

What does this PR do?

It does add the option to settle the final proof over AggLayer with a soundness check.

Reviewers

Main reviewers:

TBD

Codeowner reviewers:

TBD

…nding aggreagtor/aggregator.go code

…, and aggregator/config

cla-bot · 2024-01-16T10:29:28Z

We require contributors/corporates @nivida to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

nivida · 2024-01-16T10:31:27Z

FYI: Beethoven is still a private repository and until we put it out to the public will those CI tasks fail.

aggregator/aggregator.go

tclemos · 2024-01-16T16:42:00Z

Since the PR is WIP, I'm converting it to draft until it is ready to be reviewed and merged.

cla-bot · 2024-01-19T14:47:05Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

cla-bot · 2024-01-19T14:48:35Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

cla-bot · 2024-01-19T16:37:39Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

cla-bot · 2024-01-19T17:44:27Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

In some circumstances, we've encountered panics when using the empty struct for the stacktrie because the hasher is nil. This commit switches to using `NewSTackTrie` to create the object and avoids those panics.

cla-bot · 2024-01-22T15:01:28Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

Not sure if this was already implemented and can be reused.

cla-bot · 2024-01-23T16:13:42Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

nivida · 2024-01-23T16:16:42Z

config/config.go

@@ -183,3 +187,19 @@ func Load(ctx *cli.Context, loadNetworkConfig bool) (*Config, error) {
 	}
 	return cfg, nil
 }
+
+// NewKeyFromKeystore creates a private key from a keystore file
+func NewKeyFromKeystore(cfg types.KeystoreFileConfig) (*ecdsa.PrivateKey, error) {


We could also already apply the related changes from Arnau here. See here.

…integration

cla-bot · 2024-02-01T16:08:48Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

…quential by default (#3191) * fix getting URL from contract in compatibility mode * synchronizer configuration by default use `sequential` mode

* fix isSynced * fix linter * fix logs * halt on sanity check error

…3190)

* allow rpc to access the ForkID directly from DB * update docs

* allow rpc to access the ForkID directly from DB * update docs * fix migration down; check for greater forkIDs instead of the next +1 (#3182) * fix state storage config initialization * add tests and fix get forkID by block number * fix test TestGetForkIDByBlockNumber --------- Co-authored-by: agnusmor <agnusmor@gmail.com>

* L1InfooTree cache is calculated when needed and is discard when a reorg happens

* synchronizer avoid panic if process trusted batch fails

… (it will use default "sequential" value) (#3210)

* set l2 block gas limit to 2**50 (1125899906842624) * limit L2 block gasLimit in StoreL2Block function

* fix stream * fix stream * fix stream * fix stream * linter

…than last SC sequenced batcj (#3225)

…batch table (#3234)

…ne. Do fatal for some finalizer halt events. Several fixes. Optmize purge pool (#3241) * sequence batch only when sanity check is done. Do fatal for some halt events. Several fixes * feat: optimize purge txn pool query (#3137) * feat: optimize purge txn pool query * fix: add new method to state interface * feat: generate new state mocks * fix merge * fix %w --------- Co-authored-by: Idris Hanafi <ifh101@gmail.com>

cla-bot · 2024-02-13T17:21:08Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

cla-bot · 2024-02-13T17:23:08Z

We require contributors/corporates @nivida, @vcastellm to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

nivida added 6 commits January 12, 2024 14:54

draft integration of beethoven endpoint for proof settlement

7914028

Getter added for RollupID to the etherman struct and updated the depe…

05b033d

…nding aggreagtor/aggregator.go code

trusted sequencer private key added to cmd/run, aggregator/aggregator…

0888768

…, and aggregator/config

overtook aggregator_test changes from Arnau's PR

4abe334

etherman mock for aggregator test updated with mockery

a04fa54

dependencies updated

bd64c7b

nivida requested review from ARR552, joanestebanr, tclemos, ToniRamirezM and agnusmor as code owners January 16, 2024 10:29

Stefan-Ethernal reviewed Jan 16, 2024

View reviewed changes

aggregator/aggregator.go Outdated Show resolved Hide resolved

tclemos marked this pull request as draft January 16, 2024 16:41

Merge remote-tracking branch 'origin' into feature/beethoven-integration

1eced59

Go get

5c48881

agnusmor and others added 2 commits January 19, 2024 17:19

fix smtProof

44a23ee

Go sum

e2879d2

Merge tag 'v0.5.0-RC19' into feature/beethoven-integration

02d5a48

fix: using constructor to create StackTrie

5431256

In some circumstances, we've encountered panics when using the empty struct for the stacktrie because the hasher is nil. This commit switches to using `NewSTackTrie` to create the object and avoids those panics.

Load PK from Keystore file config

6a468ec

Not sure if this was already implemented and can be reused.

nivida commented Jan 23, 2024

View reviewed changes

vcastellm added 2 commits February 1, 2024 17:07

Merge remote-tracking branch 'origin/develop' into feature/beethoven-…

0faaad7

…integration

Merge latest changes

36930bb

joanestebanr and others added 5 commits February 1, 2024 17:42

Fix/3164 eth syncing dont return expected values (#3165)

10aaffb

fix im state root in stream (#3192)

f3dfbf2

sync: fix getting URL from contract in compatibility mode, and set se…

6f81efa

…quential by default (#3191) * fix getting URL from contract in compatibility mode * synchronizer configuration by default use `sequential` mode

Fix isSynced function (#3188)

175e0f3

* fix isSynced * fix linter * fix logs * halt on sanity check error

fix l2 block gas price to use value returned by the executor (#3186) (#…

3567c84

…3190)

This was referenced Feb 2, 2024

Feature/agglayer #3195

Closed

Feature/agglayer 0xPolygon/cdk-validium-node#67

Open

tclemos and others added 17 commits February 2, 2024 22:34

allow rpc to access the ForkID directly from DB (#3196)

284dda3

* allow rpc to access the ForkID directly from DB * update docs

Fix/3200 l1inforoot error on reorg (#3201)

112bdd0

* L1InfooTree cache is calculated when needed and is discard when a reorg happens

Fix/3203 panic if batch process fail and must be closed (#3206)

a4059e6

* synchronizer avoid panic if process trusted batch fails

Remove L1SynchronizationMode parameter from environments config files…

d439c9f

… (it will use default "sequential" value) (#3210)

allow GetL2TxHashByTxHash to return null for txs prior to Etrog (#3209)

78ba11d

Fix L2 block gas limit to 2**50 (1125899906842624) (#3219)

d85d135

* set l2 block gas limit to 2**50 (1125899906842624) * limit L2 block gasLimit in StoreL2Block function

change 2^64-1 for an esmitation of blocks (#3220)

c29d96c

removed restart RPC on deploy instructions (#3221)

e616ee5

Cherry pick/3222 (#3224)

18b38d7

* fix stream * fix stream * fix stream * fix stream * linter

add retries in is Synced function when last virtual batch is greater …

bab6187

…than last SC sequenced batcj (#3225)

Fix/3233 the etrog event UpdateEtrogSequence doesnt store the GER in …

1d3f6ee

…batch table (#3234)

remove state.batch section from environments config files (#3230)

3d53b55

get GER for l2block on Etrog (#3238)

8d135de

fix node OOC (#3263)

9828977

Merge tag 'v0.5.9' into feature/beethoven-integration

8b1ba7d

oops

4ec009a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] AggLayer integration #3083

[WIP] AggLayer integration #3083

nivida commented Jan 16, 2024 •

edited by vcastellm

Loading

cla-bot bot commented Jan 16, 2024

nivida commented Jan 16, 2024

tclemos commented Jan 16, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 22, 2024

cla-bot bot commented Jan 23, 2024

nivida Jan 23, 2024

cla-bot bot commented Feb 1, 2024

cla-bot bot commented Feb 13, 2024

cla-bot bot commented Feb 13, 2024

[WIP] AggLayer integration #3083

Are you sure you want to change the base?

[WIP] AggLayer integration #3083

Conversation

nivida commented Jan 16, 2024 • edited by vcastellm Loading

What does this PR do?

Reviewers

cla-bot bot commented Jan 16, 2024

nivida commented Jan 16, 2024

tclemos commented Jan 16, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 19, 2024

cla-bot bot commented Jan 22, 2024

cla-bot bot commented Jan 23, 2024

nivida Jan 23, 2024

Choose a reason for hiding this comment

cla-bot bot commented Feb 1, 2024

cla-bot bot commented Feb 13, 2024

cla-bot bot commented Feb 13, 2024

nivida commented Jan 16, 2024 •

edited by vcastellm

Loading